Hi Laurent, Quoting Laurent Pinchart (2022-01-02 22:48:03) > Protect against multiple inclusions of the max9271.h header with include > guards. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > --- > drivers/media/i2c/max9271.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/i2c/max9271.h b/drivers/media/i2c/max9271.h > index dc5e4e70ba6f..0bf1d40811eb 100644 > --- a/drivers/media/i2c/max9271.h > +++ b/drivers/media/i2c/max9271.h > @@ -8,6 +8,9 @@ > * Copyright (C) 2015 Cogent Embedded, Inc. > */ > > +#ifndef __MEDIA_I2C_MAX9271_H__ > +#define __MEDIA_I2C_MAX9271_H__ > + I wonder if we'll ever #pragma once outside of /tools/testing/selftests. Still, these are indeed missing and should be added. Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > #include <linux/i2c.h> > > #define MAX9271_DEFAULT_ADDR 0x40 > @@ -231,3 +234,5 @@ int max9271_set_deserializer_address(struct max9271_device *dev, u8 addr); > * Return 0 on success or a negative error code on failure > */ > int max9271_set_translation(struct max9271_device *dev, u8 source, u8 dest); > + > +#endif /* __MEDIA_I2C_MAX9271_H__ */ > -- > Regards, > > Laurent Pinchart >
