On 12/16/21 12:41, Michael Tretter wrote:
On Tue, 14 Dec 2021 11:14:58 +0100, Mauro Carvalho Chehab wrote:
Em Mon, 29 Nov 2021 12:27:08 +0100
Michael Tretter <m.tretter@xxxxxxxxxxxxxx> escreveu:
From: Marek Vasut <marex@xxxxxxx>
Add driver for the Intersil ISL7998x Analog to MIPI CSI-2/BT656 decoder.
This chip supports 1/2/4 analog video inputs and converts them into
1/2/4 VCs in MIPI CSI2 stream.
This driver currently supports ISL79987 and both 720x480 and 720x576
resolutions, however as per specification, all inputs must use the
same resolution and standard. The only supported pixel format is now
YUYV/YUV422. The chip should support RGB565 on the CSI2 as well, but
this is currently unsupported.
There are *lots* of checkpatch warnings (on strict mode) due to the
usage of CamelCase macros. Please fix. Just doing that should be enough
to solve them:
sed s,ISL7998x_REG_Px_ACA_FLEX_WIN_Y_BL_H,ISL7998X_REG_PX_ACA_FLEX_WIN_Y_BL_H,g -i drivers/media/i2c/isl7998x.c
sed s,ISL7998x,ISL7998X,g -i drivers/media/i2c/isl7998x.c
sed s,ISL7998X_REG_Pn,ISL7998X_REG_PN, -i drivers/media/i2c/isl7998x.c
sed s,ISL7998X_REG_Pn,ISL7998X_REG_PN,g -i drivers/media/i2c/isl7998x.c
sed s,ISL7998X_REG_PX,ISL7998X_REG_PX,g -i drivers/media/i2c/isl7998x.c
sed s,ISL7998X_REG_Px,ISL7998X_REG_PX,g -i drivers/media/i2c/isl7998x.c
These are easy to fix.
Isn't that counter-productive to rename Pn (which represents P0, P1,
P2...) to PN which is hard to tell what it represents ?
I would say checkpatch strict mode is wrong here and the Pn is more
readable.
Note that there is sed 's@\<ISL7998[^ ]\+\>@\U&@' regex too which turns
all those macros into uppercase if that's what you're after, but I don't
like that approach.
[...]
