On Mon, Jun 21, 2010 at 2:59 AM, Luca Olivetti <luca@xxxxxxxxxxx> wrote: > En/na Michael Krufky ha escrit: >> >> Could somebody please test this patch and confirm that it doesn't >> break the af9005 support? >> >> This patch removes the af9005_usb_generic_rw function and uses the >> dvb_usb_generic_rw function instead, using >> generic_bulk_ctrl_endpoint_response to differentiate between the read >> pipe and the write pipe. > > Unfortunately I cannot test it (my device is broken)[*]. > At the time I wrote my own rw function because I didn't find a way to send > on a bulk endpoint and receiving on another one (i.e. I didn't know about > generic_bulk_ctrl_endpoint/generic_bulk_ctrl_endpoint_response or they > weren't available at the time). > > [*]Actually the tuner is broken, but the usb is working fine, so maybe I can > give it a try. Luca, That's OK -- I only added this "generic_bulk_ctrl_endpoint_response" feature 4 months ago -- your driver predates that. I am pushing this patch to reduce the size of the kernel while using your driver to demonstrate how to use the new feature. I am already using it in an out of tree driver that I plan to merge within the next few months or so, but its always nice to optimize code that already exists with small cleanups like this. You don't need the tuner in order to prove the patch -- if you can simply confirm that you are able to both read and write successfully, that would be enough to prove the patch. After testing, please provide an ack in this thread so that I may include that with my pull request. Thanks & regards, Mike Krufky -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
