As pointed bt Robert, if there's already a firmware for si2157 at /lib/firmware, it is preferred to use it, instead of the default firmware. Yet, when this is missed, the driver may still work. That's the case, for instance, of the devices explicitly flagged with dont_load_firmware (currently, Terratec Cinergy TC2). So, rework the firmware logic in a way that it will emit a warning for devices that are using the eeprom firmware and may not work well with it. Compile-tested only. -- v3: - Rename some data structs; - Better handle the cases where the ROM is unknown. v2: - added a patch to allow supporting different firmwares depending on the device's reported ROM ID. Mauro Carvalho Chehab (3): media: si2157: move firmware load to a separate function media: si2157: rework the firmware load logic media: si2157: use a different namespace for firmware Robert Schlabbach (1): media: si2157: Add optional firmware download drivers/media/tuners/si2157.c | 254 +++++++++++++++++------------ drivers/media/tuners/si2157_priv.h | 31 ++++ 2 files changed, 184 insertions(+), 101 deletions(-) -- 2.33.1
