Cc: Antti Palosaari <crope@xxxxxx> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> Cc: Robert Schlabbach <robert_s@xxxxxxx> Cc: Olli Salonen <olli.salonen@xxxxxx> Cc: linux-kernel@xxxxxxxxxxxxxxx Cc: linux-media@xxxxxxxxxxxxxxx While the eeprom firmware files for such devices are know to work, if there is a firmware file, use it instead, as a newer version could have solved some tuning issues. Compile-tested only. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> --- At least on my eyes, it makes sense to also allow to optionally load A10 and A30 firmware files for SI2146_A10 and SI147_A30. Yet, before applying this one, someone needs to report that those devices will keep working with the loaded firmware files. drivers/media/tuners/si2157.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c index 5f4ae8593864..f970bedfb179 100644 --- a/drivers/media/tuners/si2157.c +++ b/drivers/media/tuners/si2157.c @@ -205,19 +205,19 @@ static int si2157_init(struct dvb_frontend *fe) case SI2148_A20: fw_name = SI2158_A20_FIRMWARE; break; + case SI2146_A10: + fw_required = false; + fallthrough; case SI2141_A10: fw_name = SI2141_A10_FIRMWARE; break; + case SI2147_A30: case SI2157_A30: fw_required = false; fallthrough; case SI2177_A30: fw_name = SI2157_A30_FIRMWARE; break; - case SI2147_A30: - case SI2146_A10: - fw_name = NULL; - break; default: dev_err(&client->dev, "unknown chip version Si21%d-%c%c%c\n", cmd.args[2], cmd.args[1], -- 2.33.1
