Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on media-tree/master] [also build test ERROR on wsa/i2c/for-next broonie-regulator/for-next clk/clk-next linus/master v5.16-rc4 next-20211206] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/Add-support-for-X86-ACPI-camera-sensor-PMIC-setup-with-clk-and-regulator-platform-data/20211203-183202 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-a003-20211207 (https://download.01.org/0day-ci/archive/20211207/202112071424.x9BP4OXf-lkp@xxxxxxxxx/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/82c6f06c3746e7a9b2f95bf534d633b66ae89b97 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Hans-de-Goede/Add-support-for-X86-ACPI-camera-sensor-PMIC-setup-with-clk-and-regulator-platform-data/20211203-183202 git checkout 82c6f06c3746e7a9b2f95bf534d633b66ae89b97 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/media/pci/intel/ipu3/cio2-bridge.c: In function 'cio2_bridge_unregister_sensors': >> drivers/media/pci/intel/ipu3/cio2-bridge.c:254:3: error: implicit declaration of function 'i2c_unregister_device'; did you mean 'spi_unregister_device'? [-Werror=implicit-function-declaration] 254 | i2c_unregister_device(sensor->vcm_i2c_client); | ^~~~~~~~~~~~~~~~~~~~~ | spi_unregister_device cc1: some warnings being treated as errors vim +254 drivers/media/pci/intel/ipu3/cio2-bridge.c 243 244 static void cio2_bridge_unregister_sensors(struct cio2_bridge *bridge) 245 { 246 struct cio2_sensor *sensor; 247 unsigned int i; 248 249 for (i = 0; i < bridge->n_sensors; i++) { 250 sensor = &bridge->sensors[i]; 251 software_node_unregister_nodes(sensor->swnodes); 252 ACPI_FREE(sensor->pld); 253 acpi_dev_put(sensor->adev); > 254 i2c_unregister_device(sensor->vcm_i2c_client); 255 } 256 } 257 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
