On Sun, 2010-06-20 at 11:58 -0400, Jarod Wilson wrote: > On Jun 20, 2010, at 3:20 AM, Joe Perches <joe@xxxxxxxxxxx> wrote: > Use the standard error logging mechanisms. > > Add #define pr_fmt(fmt) KBUILD_MODNAME ":%s" fmt, __func__ > > Remove __func__ from err calls, add '\n', rename to pr_err > Eh. If we're going to make a change here, I'd rather it be to using > dev_err instead, since most of the other spew in this driver uses > similar. The idea is to eventually remove info/err/warn from usb.h by changing the code outside of drivers/usb first. There will always be some mix of printk or pr_<level> along with dev_<level> because struct device * is NULL or as is mostly used here there's no struct imon_context * available. I suggest you have a look and see which ones of these changes could use dev_<level> instead. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
