Can someone share what is the process to get a patch into the mainstream codes?
It been quite a while already and its still been review. Seem like a
waste if this patch disappear again just like the previous time when
it was submitted long ago.
On Sun, May 30, 2010 at 8:22 AM, Bee Hock Goh <beehock@xxxxxxxxx> wrote:
> Hi Lauris,
>
> thanks for the reply. I am just a user. :)
>
> As you are the original driver developer, it would great if you could
> endorsed/ack the patch sent by Nikola.
>
> thanks,
> Hock.
>
> On Sun, May 30, 2010 at 12:07 AM, Lauris Ding <lding@xxxxxx> wrote:
>> On 29.05.2010 11:39, Bee Hock Goh wrote:
>>>
>>> Dear Lauris,
>>>
>>> Are you still active? Nikola have submitted a patch for af9015/tda18218.
>>>
>>> Could you maybe spend some time to help and endorsed it?
>>>
>>> thanks,
>>> Hock.
>>>
>>>
>>> ---------- Forwarded message ----------
>>> From: Antti Palosaari<crope@xxxxxx>
>>> Date: Sat, May 29, 2010 at 2:25 AM
>>> Subject: Re: [PATCH] V4L/DVB: New NXP tda18218 tuner
>>> To: Nikola Pajkovsky<npajkovs@xxxxxxxxxx>
>>> Cc: linux-media@xxxxxxxxxxxxxxx
>>>
>>>
>>> Terve,
>>>
>>> On 05/20/2010 12:52 PM, Nikola Pajkovsky wrote:
>>>
>>>>
>>>> Signed-off-by: Nikola Pajkovsky<npajkovs@xxxxxxxxxx>
>>>> ---
>>>> drivers/media/common/tuners/Kconfig | 7 +
>>>> drivers/media/common/tuners/Makefile | 1 +
>>>> drivers/media/common/tuners/tda18218.c | 432
>>>> +++++++++++++++++++++++++++
>>>> drivers/media/common/tuners/tda18218.h | 44 +++
>>>> drivers/media/common/tuners/tda18218_priv.h | 36 +++
>>>> drivers/media/dvb/dvb-usb/af9015.c | 13 +-
>>>> drivers/media/dvb/frontends/af9013.c | 15 +
>>>> drivers/media/dvb/frontends/af9013_priv.h | 5 +-
>>>> 8 files changed, 548 insertions(+), 5 deletions(-)
>>>> create mode 100644 drivers/media/common/tuners/tda18218.c
>>>> create mode 100644 drivers/media/common/tuners/tda18218.h
>>>> create mode 100644 drivers/media/common/tuners/tda18218_priv.h
>>>>
>>>
>>> tda18218_write_reg() could use tda18218_write_regs()
>>>
>>> tda18218_set_params() correct frequency limits. No need to check both
>>> upper and lower limit.
>>>
>>> printk(KERN_INFO "We've got a lock!");
>>> it does not sounds good idea to print INFO when lock
>>>
>>> while(i< 10) {
>>> use for loop insted. Two rows less code.
>>>
>>> tda18218_init()
>>> why return -EREMOTEIO; ?
>>>
>>> tda18218_attach()
>>> printk(KERN_WARNING "Device is not a TDA18218!\n");
>>> we should fail without noise since many times tuner attach is used for
>>> probe correct tuner
>>>
>>> A lot of error checkings are missing when reg write / read
>>>
>>> checkpatch returns a lot of warnings and for errors too almost every
>>> file changed
>>>
>>> Is that checked TDA18218 uses same demod settings as TDA18271?
>>>
>>> And the biggest problem is that driver author Lauris haven't replied
>>> any mails...
>>>
>>> regards
>>> Antti
>>>
>>>
>>> --
>>> http://palosaari.fi/
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
>>>
>>
>> Hi,
>>
>> well, I've stopped doing anything on it after I finally got it working, as
>> it was enough for me having it just working, more or less regardless of what
>> the code looked like.
>>
>> I very much appreciate your work on it, but I'm quite unexperienced in
>> kernel programming; I'll try to help whenever I can from now on, though.
>>
>> Regards, Lauris
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
