Hej Rikard, Tack för din patch, ser bra ut. On 2021-11-27 10:49:44 +0100, Rikard Falkeborn wrote: > The only usage of max96712_subdev_ops is to pass its address to > v4l2_i2c_subdev_init() which takes a pointer to const struct > v4l2_subdev_ops as argument. Make it const to allow the compiler to put > it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@xxxxxxxxx> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > --- > drivers/staging/media/max96712/max96712.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c > index 847e2ffd4f53..9bc72d9a858b 100644 > --- a/drivers/staging/media/max96712/max96712.c > +++ b/drivers/staging/media/max96712/max96712.c > @@ -250,7 +250,7 @@ static const struct v4l2_subdev_pad_ops max96712_pad_ops = { > .set_fmt = max96712_get_pad_format, > }; > > -static struct v4l2_subdev_ops max96712_subdev_ops = { > +static const struct v4l2_subdev_ops max96712_subdev_ops = { > .video = &max96712_video_ops, > .pad = &max96712_pad_ops, > }; > -- > 2.34.1 > -- Kind Regards, Niklas Söderlund