On Tue, Nov 23, 2021 at 11:35:33AM +0000, Eugen.Hristev@xxxxxxxxxxxxx wrote: > On 11/23/21 1:25 PM, Sakari Ailus wrote: > > > Hi Eugen, > > > > On Tue, Nov 23, 2021 at 01:15:20PM +0200, Eugen Hristev wrote: > >> Simplify probe function by adding a local variable dev instead of using > >> &client->dev all the time. > >> > >> Signed-off-by: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx> > > > > It's not really wrong to do this, but is it useful? > > > > You can't even unwrap a single line, the lines are just made a little bit > > shorter. > > Hi, > > I think there are a few (18 +, 21 -) ... but the idea was to make the Indeed you're right. > probe function a little bit more easy to read. > Up to you if you want to take this patch. I'll take it. -- Sakari Ailus
