On Wed, Nov 17, 2021 at 11:19:56AM +0000, Mauro Carvalho Chehab wrote: > Em Wed, 17 Nov 2021 13:02:38 +0300 > Dan Carpenter <dan.carpenter@xxxxxxxxxx> escreveu: > > > On Wed, Nov 17, 2021 at 09:25:38AM +0000, Mauro Carvalho Chehab wrote: > > > As we're using Intel Aero firmware, make the code closer to the > > > driver for such device. > > > > I don't really understand this commit message. Is there a out of tree > > Intel driver? > > Yes. It is at: > > https://github.com/intel-aero/meta-intel-aero-base/tree/master/recipes-kernel/linux/linux-yocto > Fine, but only removing the if (stage == 0) { is correct. The other two changes are harmless but wrong. regards, dan carpenter