Re: [PATCH 03/13] media: atomisp: sh_css_metrics: drop some unused code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 17, 2021 at 09:25:28AM +0000, Mauro Carvalho Chehab wrote:
>  .../media/atomisp/pci/sh_css_metrics.c        | 25 -------------------
>  1 file changed, 25 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_metrics.c b/drivers/staging/media/atomisp/pci/sh_css_metrics.c
> index 9744bbebe1bc..8ded6cdd1575 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_metrics.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_metrics.c
> @@ -123,40 +123,15 @@ sh_css_metrics_sample_pcs(void)
>  	unsigned int pc;
>  	unsigned int msink;
>  
> -#if SUSPEND
> -	unsigned int sc = 0;
> -	unsigned int stopped_sc = 0;
> -	unsigned int resume_sc = 0;
> -#endif
>  
> -#if MULTIPLE_PCS
> -	int i;
> -	unsigned int pc_tab[NOF_PCS];
> -
> -	for (i = 0; i < NOF_PCS; i++)
> -		pc_tab[i] = 0;
> -#endif
>  
>  	if (!pc_histogram_enabled)
>  		return;

There are three blank lines in a row now.  Checkpatch is not smart
enough to spot this until you re-run it with the -f file mode after
applying the patch.

This is an easy mistake to make and you did it a couple times in
yesterday's patchset as well.  No big deal.  Could you re-run
checkpatch.pl at the end and clean it up afterwards?

regards,
dan carpenter



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux