Hi Martin, No need for a v2, I've fixed up the subject line and will merge it. Just remember it for the next time you post a patch :-) Regards, Hans On 11/11/2021 17:17, Philipp Zabel wrote: > Hi Martin, > > On Tue, 2021-11-09 at 11:43 +0000, Martin Weber wrote: >> support greyscale pix fmt input for coda9_jpeg_encoder. The hardware >> supports it, so allow V4L2 Mem2Mem JPEG Encoder use it as well. Tested >> on an i.MX6QP. >> >> Signed-off-by: Martin S. Weber <martin.weber@xxxxxxxxxxxxxxxxx> > > thank you for the patch! I never tested grayscale encoding, so I didn't > expect it to work out of the box :) > > The code is fine, just a small formal issue: the subject should be in > the style used in the media subsystem. For example: > > media: coda: V4L2_PIX_FMT_GREY for coda960 JPEG encoder > > (note that there is no V4L2_PIX_FMT_GREYSCALE). Please resend a v2 with > the subject fixed and feel free to add: > > Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > > regards > Philipp >
