Em Mon, 8 Nov 2021 13:09:02 +0300
Dan Carpenter <dan.carpenter@xxxxxxxxxx> escreveu:
> On Fri, Nov 05, 2021 at 09:51:38AM +0000, Mauro Carvalho Chehab wrote:
> > ---
> > drivers/staging/media/atomisp/pci/atomisp_fops.c | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c
> > index 7df982c80b1a..41fa0ca2d8d4 100644
> > --- a/drivers/staging/media/atomisp/pci/atomisp_fops.c
> > +++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c
> > @@ -782,6 +782,15 @@ static int atomisp_open(struct file *file)
> > * FIXME: revisit this with a better check once the code structure
> > * is cleaned up a bit more
> > */
> > +dev_info(isp->dev, "opening v4l2 fh\n");
>
> This line looks like debugging code that was committed accidentally?
> Not indented.
Yep.
> Doesn't apply for on latest linux-next. Not sure why.
Yeah, I dropped it when I applied the patch on media_stage.
I should have sent v2 without that line.
>
> regards,
> dan carpenter
>
> > + ret = v4l2_fh_open(file);
> > + if (ret) {
> > + dev_err(isp->dev,
> > + "%s: v4l2_fh_open() returned error %d\n",
> > + __func__, ret);
> > + rt_mutex_unlock(&isp->loading);
> > + return ret;
> > + }
>
