On Tue, Nov 02, 2021 at 06:05:23PM +0300, Dan Carpenter wrote: > On Tue, Nov 02, 2021 at 04:45:20PM +0200, Andy Shevchenko wrote: > > On Tue, Nov 2, 2021 at 4:44 PM Andy Shevchenko > > <andy.shevchenko@xxxxxxxxx> wrote: > > > On Tue, Nov 2, 2021 at 3:10 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > > > On Mon, Oct 18, 2021 at 01:23:34AM +0900, Tsuchiya Yuto wrote: ... > > > > Run your patches through scripts/checkpatch.pl. > > > > > > While it's good advice, we are dealing with quite a bad code under > > > staging, so the requirements may be relaxed. > > > > To be more clear: the goal now is getting it _working_. That's why > > this kind of noise is not important _for now_. > > If it's a new driver, then we accept all sorts of garbage, that's true. It was in kernel for a while, but never worked (hence anyhow tested) up to the recent effort made by Tsuchiya. In any case, as I said, we shall run checkpatch in the future when we have something working. -- With Best Regards, Andy Shevchenko
