Re: [PATCH 1/1] max96712: Select VIDEO_V4L2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sakari,

Quoting Sakari Ailus (2021-11-01 13:25:02)
> Select VIDEO_V4L2 for the driver actually depends on it, failing to
> compile otherwise.
> 
> Fixes: 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer")

I guess this is a local commit in your tree so far, I can't identify it.

> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> ---
>  drivers/staging/media/max96712/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig
> index 258d47644cbd..492a7ff70dd8 100644
> --- a/drivers/staging/media/max96712/Kconfig
> +++ b/drivers/staging/media/max96712/Kconfig
> @@ -6,6 +6,7 @@ config VIDEO_MAX96712
>         select V4L2_FWNODE
>         select VIDEO_V4L2_SUBDEV_API
>         select MEDIA_CONTROLLER
> +       select VIDEO_V4L2

I don't see any other driver 'select' VIDEO_V4L2...
Most 'depend' on VIDEO_V4L2 instead.

And curiously, I already see
 - Add 'depends on VIDEO_V4L2'

in Niklas' v4.

Is this one a special case that 'needs' to select it?
--
Kieran



>         help
>           This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer.
>  
> -- 
> 2.30.2
>




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux