Re: Need help in debugging "memory leak in em28xx_init_dev"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/1/21 12:58, Dongliang Mu wrote:
On Mon, Nov 1, 2021 at 5:43 PM Pavel Skripkin <paskripkin@xxxxxxxxx> wrote:

On 11/1/21 12:41, Dongliang Mu wrote:
>> Hi, Dongliang,
>>
>> Did patch attached to my previous email pass syzbot's reproducer test?
>> Unfortunately, I am not able to test rn :(
>
> Yes, it works. The memory leak does not occur anymore.
>
> But I am crafting another patch based on yours as there is a small
> issue in the retval and I would like to make the error handling code
> uniform.
>

Cool! Thank you for confirmation.

Hi Pavel,

Thanks for your advice. I have sent the patch and you are on the CC
list. Can you please take a look at and review my patch?

It should cover your patch. But I am not sure if I introduce any new
issue in the patch.


The patch LGTM, but I can't drop R-b tag, since I am not an expert in this driver. Anyway, there is 100% missing clean up, so, I believe, you don't introduce new bugs



With regards,
Pavel Skripkin



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux