Hello Uwe, > Doing this here introduces a change in behaviour. Better do this after > pwm_get(). I didn't really get this feedback. Isn't pwm_init_state after pwm_get? Or should it be before the error treatment of pwm_get? > Conceptually this last hunk belongs in a separate patch. And you don't > need to repeat PTR_ERR(pwm), as dev_err_probe already emits this > information. So > > return dev_err_probe(&dev->dev, PTR_ERR(pwm), "pwm_get failed\n"); > > should be fine. Thank you for the suggestion! I will fix it on v2. Maíra
