Hi Hans On Thu, 21 Oct 2021 at 22:57, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > > I'll make a new PR for this without the clk patch. Sure. > > Sorry Dillon, after digging a bit more into the clk series I think that this > should go to the CLK subsystem. I do not feel comfortable merging that patch > via the media subsystem because: 1) from what I can see it is part of a larger > unmerged patch series, and 2) I do not have the expertise to tell if this is > correct or not to just merge this patch. That's fine thanks, there is no reason for clk patch not to be merged via clk subsystem. I can follow up on clk and dts patches, thanks for quick response on my media driver review. Best Regards Dillon > > Regards, > > Hans > > On 21/10/2021 16:45, Hans Verkuil wrote: > > The following changes since commit 57c3b9f55ba875a6f6295fa59f0bdc0a01c544f8: > > > > media: venus: core: Add sdm660 DT compatible and resource struct (2021-10-21 14:26:19 +0100) > > > > are available in the Git repository at: > > > > git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16k > > > > for you to fetch changes up to b019395c863f436adb30237b50f22b027bec7351: > > > > media: stm32-dma2d: STM32 DMA2D driver (2021-10-21 16:14:57 +0200) > > > > ---------------------------------------------------------------- > > Tag branch > > > > ---------------------------------------------------------------- > > Dillon Min (8): > > media: admin-guide: add stm32-dma2d description > > media: dt-bindings: media: add document for STM32 DMA2d bindings > > media: v4l2-mem2mem: add v4l2_m2m_get_unmapped_area for no-mmu platform > > media: videobuf2: Fix the size printk format > > media: v4l2-ctrls: Add V4L2_CID_COLORFX_CBCR max setting > > media: v4l2-ctrls: Add RGB color effects control > > clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after system enter shell > > media: stm32-dma2d: STM32 DMA2D driver > > > > Documentation/admin-guide/media/platform-cardlist.rst | 1 + > > Documentation/devicetree/bindings/media/st,stm32-dma2d.yaml | 71 +++++ > > Documentation/userspace-api/media/v4l/control.rst | 9 + > > drivers/clk/clk-stm32f4.c | 4 - > > drivers/media/common/videobuf2/videobuf2-dma-contig.c | 8 +- > > drivers/media/platform/Kconfig | 11 + > > drivers/media/platform/Makefile | 1 + > > drivers/media/platform/stm32/Makefile | 2 + > > drivers/media/platform/stm32/dma2d/dma2d-hw.c | 143 ++++++++++ > > drivers/media/platform/stm32/dma2d/dma2d-regs.h | 113 ++++++++ > > drivers/media/platform/stm32/dma2d/dma2d.c | 739 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > > drivers/media/platform/stm32/dma2d/dma2d.h | 135 ++++++++++ > > drivers/media/v4l2-core/v4l2-ctrls-defs.c | 12 +- > > drivers/media/v4l2-core/v4l2-mem2mem.c | 21 ++ > > include/media/v4l2-mem2mem.h | 5 + > > include/uapi/linux/v4l2-controls.h | 4 +- > > 16 files changed, 1268 insertions(+), 11 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/media/st,stm32-dma2d.yaml > > create mode 100644 drivers/media/platform/stm32/dma2d/dma2d-hw.c > > create mode 100644 drivers/media/platform/stm32/dma2d/dma2d-regs.h > > create mode 100644 drivers/media/platform/stm32/dma2d/dma2d.c > > create mode 100644 drivers/media/platform/stm32/dma2d/dma2d.h > > >