Em Thu, 21 Oct 2021 16:10:08 +0200 Hans Verkuil <hverkuil@xxxxxxxxx> escreveu: > There is one other requirement: the patches must be run through > scripts/checkpatch.pl --strict. Anything that --strict notifies you of and > that is reasonable to fix (not everything can be fixed) should be fixed. This is already there: Coding Style Addendum +++++++++++++++++++++ Media development uses ``checkpatch.pl`` on strict mode to verify the code style, e.g.:: $ ./scripts/checkpatch.pl --strict --max-line-length=80 > > Also (although perhaps out of scope for a coding style) before new V4L2 > drivers or substantial enhancements to V4L2 drivers can be accepted, you must > run 'v4l2-compliance -s' for the video device (or even better use -m if the driver > creates a media device) and include the output with the cover letter of > the patch series. Obviously, any failures should be fixed. This is also there: There is a set of compliance tools at https://git.linuxtv.org/v4l-utils.git/ that should be used in order to check if the drivers are properly implementing the media APIs: ==================== ======================================================= Type Tool ==================== ======================================================= V4L2 drivers\ [3]_ ``v4l2-compliance`` V4L2 virtual drivers ``contrib/test/test-media`` CEC drivers ``cec-compliance`` ==================== ======================================================= .. [3] The ``v4l2-compliance`` also covers the media controller usage inside V4L2 drivers. Other compilance tools are under development to check other parts of the subsystem. Those tests need to pass before the patches go upstream. Regards, Mauro
