Re: [PATCH v2 3/9] media: platform: mtk-mdp3: add chip independence architecture

[AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>]

Il 20/10/21 09:14, roy-cw.yeh ha scritto:
> From: "Roy-CW.Yeh" <roy-cw.yeh@xxxxxxxxxxxx>
>
> Add chip independence architecture
> - Add hal architecture for mt8183
> - Add driver data to adapt other soc
>
> Signed-off-by: Roy-CW.Yeh <roy-cw.yeh@xxxxxxxxxxxx>
> ---
>   .../media/platform/mtk-mdp3/mtk-mdp3-cmdq.c   | 154 ++++---
>   .../media/platform/mtk-mdp3/mtk-mdp3-comp.c   | 181 ++++-----
>   .../media/platform/mtk-mdp3/mtk-mdp3-comp.h   | 193 ++++++++-
>   .../media/platform/mtk-mdp3/mtk-mdp3-core.c   | 383 +++++++++++++++++-
>   .../media/platform/mtk-mdp3/mtk-mdp3-core.h   |  19 +
>   .../media/platform/mtk-mdp3/mtk-mdp3-m2m.c    |  10 +-
>   .../media/platform/mtk-mdp3/mtk-mdp3-regs.c   | 259 +-----------
>   .../media/platform/mtk-mdp3/mtk-mdp3-regs.h   | 268 ++++++------
>   8 files changed, 925 insertions(+), 542 deletions(-)

snip...

> diff --git a/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c b/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c
> index a6caefb097be..50fd5430a565 100644
> --- a/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c
> +++ b/drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c

snip..

> @@ -732,7 +514,7 @@ int mdp_frameparam_init(struct mdp_frameparam *param)
>   	param->num_captures = 1;
>   	frame = &param->captures[0];
>   	frame->format.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
> -	frame->mdp_fmt = mdp_try_fmt_mplane(&frame->format, param, 0);
> +	frame->mdp_fmt = mdp_try_fmt_mplane(mdp, &frame->format, param, 0);
>   	frame->ycbcr_prof =
>   		mdp_map_ycbcr_prof_mplane(&frame->format,
>   					  frame->mdp_fmt->mdp_color);
> @@ -744,3 +526,4 @@ int mdp_frameparam_init(struct mdp_frameparam *param)
>   
>   	return 0;
>   }
> +

Please remove this empty new line.

Apart from that,

Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>