Re: [GIT PULL FOR v5.16] Allegro fixes/enhancements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mauro,

On 18/10/2021 10:40, Mauro Carvalho Chehab wrote:
> Em Mon, 11 Oct 2021 10:49:14 +0200
> Hans Verkuil <hverkuil@xxxxxxxxx> escreveu:
> 
>> The following changes since commit fd2eda71a47b095e81b9170c3f8b7ae82b04e785:
>>
>>   media: remove myself from dvb media maintainers (2021-10-08 13:56:25 +0200)
>>
>> are available in the Git repository at:
>>
>>   git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.16i
>>
>> for you to fetch changes up to 8f472ea73758255b366fae57bde772396231efcd:
>>
>>   media: allegro: write vui parameters for HEVC (2021-10-11 10:18:33 +0200)
>>
>> ----------------------------------------------------------------
>> Tag branch
>>
>> ----------------------------------------------------------------
>> Michael Tretter (13):
>>       media: allegro: ignore interrupt if mailbox is not initialized
>>       media: allegro: fix module removal if initialization failed
>>       media: allegro: lookup VCU settings
>>       media: allegro: add pm_runtime support
>>       media: allegro: add encoder buffer support
>>       media: allegro: add control to disable encoder buffer
>>       media: allegro: fix row and column in response message
>>       media: allegro: remove external QP table
>>       media: allegro: correctly scale the bit rate in SPS
>>       media: allegro: extract nal value lookup functions to header
>>       media: allegro: write correct colorspace into SPS
>>       media: allegro: nal-hevc: implement generator for vui
>>       media: allegro: write vui parameters for HEVC
> 
> Jenkins is reporting compilation breakage when -Werror is turned on:
> 
> patches/0010-media-allegro-extract-nal-value-lookup-functions-to-.patch:
> 
>     allyesconfig: return code #512:
> 	In file included from ../drivers/media/platform/allegro-dvt/nal-hevc.c:24:
> 	../drivers/media/platform/allegro-dvt/nal-hevc.h:416:30: error: ‘enum v4l2_quantization’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 	../drivers/media/platform/allegro-dvt/nal-hevc.h:417:40: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 	../drivers/media/platform/allegro-dvt/nal-hevc.h:419:14: error: ‘enum v4l2_xfer_func’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 	../drivers/media/platform/allegro-dvt/nal-hevc.h:418:49: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 	../drivers/media/platform/allegro-dvt/nal-hevc.h:421:10: error: ‘enum v4l2_ycbcr_encoding’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 	../drivers/media/platform/allegro-dvt/nal-hevc.h:420:38: error: ‘enum v4l2_colorspace’ declared inside parameter list will not be visible
> 
> Are there any missing include?

Ah, the next two patches add the necessary videodev2.h includes. I've fixed up the
patch series to add videodev2.h to this patch instead of later patches, and will
post a new PR soon.

Michael, no need for you to do anything.

Regards,

	Hans

> 
> Regards,
> Mauro
> 




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux