Re: [PATCH v2 3/6] staging: media: wave5: Add the v4l2 layer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 10/13/21 3:56 AM, Dafna Hirschfeld wrote:
diff --git a/drivers/staging/media/wave5/Kconfig b/drivers/staging/media/wave5/Kconfig
new file mode 100644
index 000000000000..efaacf391e01
--- /dev/null
+++ b/drivers/staging/media/wave5/Kconfig
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: GPL-2.0
+config VIDEO_WAVE_VPU
+        tristate "Chips&Media Wave Codec Driver"
+        depends on VIDEO_DEV && VIDEO_V4L2 && OF
+        select VIDEOBUF2_DMA_CONTIG
+        select VIDEOBUF2_VMALLOC
+        select V4L2_MEM2MEM_DEV
+        help
+          Chips&Media stateful encoder and decoder driver.
+	  The driver supports HEVC and H264 formats.
+          To compile this driver as modules, choose M here: the
+          modules will be called wave5.

Please follow coding-style for Kconfig files:

(from Documentation/process/coding-style.rst, section 10):

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different.  Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.


Also, depending on OF is usually not necessary since there are stubs
for non-CONFIG_OF functions.  That may even allow you to add
COMPILE_TEST here.

thanks.
--
~Randy



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux