Quoting Dan Carpenter (2021-10-12 09:21:50)
> The "power" pointer is not initialized on the else path and that would
> lead to an Oops.
>
Yes, that looks like a good catch.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> Fixes: c30f4cb2d4c7 ("media: atomisp: Refactor PMIC detection to a separate function")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> index d8c9e31314b2..62dc06e22476 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> @@ -481,7 +481,7 @@ static int atomisp_get_acpi_power(struct device *dev)
>
> static u8 gmin_get_pmic_id_and_addr(struct device *dev)
> {
> - struct i2c_client *power;
> + struct i2c_client *power = NULL;
> static u8 pmic_i2c_addr;
>
> if (pmic_id)
> --
> 2.20.1
>
