On 05/10/2021 12:51, Lecopzer Chen wrote: > A case that we need VIDEO_DEV=y but DVB_CORE=m, and this doesn't > work since DVB_CORE is default MEDIA_DIGITAL_TV_SUPPORT and then > follows MEDIA_SUPPORT. > > Change to tristate to make DVB_CORE=m possible when MEDIA_SUPPORT=y > > Signed-off-by: Lecopzer Chen <lecopzer.chen@xxxxxxxxxxxx> > --- > drivers/media/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig > index b07812657cee..c3baf92b4d02 100644 > --- a/drivers/media/Kconfig > +++ b/drivers/media/Kconfig > @@ -88,7 +88,7 @@ config MEDIA_ANALOG_TV_SUPPORT > will disable support for them. > > config MEDIA_DIGITAL_TV_SUPPORT > - bool > + tristate > prompt "Digital TV" if MEDIA_SUPPORT_FILTER > default y if !MEDIA_SUPPORT_FILTER > help > I don't think this is the right approach. I think the following patch would fix the issue, and it is also in line with what config VIDEO_DEV does. What do you think, Mauro? Regards, Hans Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> --- diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig index c3baf92b4d02..46f7b1f75630 100644 --- a/drivers/media/Kconfig +++ b/drivers/media/Kconfig @@ -179,8 +179,7 @@ config MEDIA_CONTROLLER # config DVB_CORE - tristate - depends on MEDIA_DIGITAL_TV_SUPPORT + tristate "DVB core" depends on (I2C || I2C=n) default MEDIA_DIGITAL_TV_SUPPORT select CRC32
