On Thu, 2021-10-07 at 20:32 +0300, Andy Shevchenko wrote: > On Thu, Oct 07, 2021 at 10:26:05AM -0700, Joe Perches wrote: > > On Thu, 2021-10-07 at 20:19 +0300, Andy Shevchenko wrote: > > > On Thu, Oct 07, 2021 at 10:12:56AM -0700, Joe Perches wrote: > > > > On Thu, 2021-10-07 at 18:44 +0300, Andy Shevchenko wrote: > > > > > When kernel.h is used in the headers it adds a lot into dependency hell, > > > > > especially when there are circular dependencies are involved. > > > > > > > > > > Replace kernel.h inclusion with the list of what is really being used. > > > > [] > > > > > diff --git a/include/linux/plist.h b/include/linux/plist.h > > > > [] > > > > > @@ -73,8 +73,11 @@ > > > > [] > > > > > +#include <asm/bug.h> > > > > > > > > why asm/bug.h and not linux/bug.h ? > > > > > > The direct inclusion is from that one. Why linux/bug? > > > > A general guideline is to avoid asm includes. > > It's fine when it has any useful background. Doing cargo cult is not always > a good idea. I plead for common sense. Common sense isn't particularly common. Someone is going to run checkpatch on it and submit a patch one day. Maybe add a comment for the less common. cheers, Joe
