On Thu, Oct 07, 2021 at 05:16:35PM +0100, Jonathan Cameron wrote: > On Thu, 7 Oct 2021 18:44:04 +0300 Andy Shevchenko wrote: > > > When kernel.h is used in the headers it adds a lot into dependency hell, > > especially when there are circular dependencies are involved. > > > > Replace kernel.h inclusion with the list of what is really being used. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > --- > > include/linux/list.h | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/list.h b/include/linux/list.h > > index f2af4b4aa4e9..5dc679b373da 100644 > > --- a/include/linux/list.h > > +++ b/include/linux/list.h > > @@ -2,11 +2,13 @@ > > #ifndef _LINUX_LIST_H > > #define _LINUX_LIST_H > > > > +#include <linux/container_of.h> > > +#include <linux/const.h> > > #include <linux/types.h> > > #include <linux/stddef.h> > > #include <linux/poison.h> > > Is there a reason you didn't quite sort this into alphabetical order? On a side note, if someone with perle knowledge could add a checkpatch warning for this, I think it would be very nice. I'm a bit tired of asking for alphabetical order in reviews :-) > > -#include <linux/const.h> > > -#include <linux/kernel.h> > > + > > +#include <asm/barrier.h> > > > > /* > > * Circular doubly linked list implementation. -- Regards, Laurent Pinchart
