Hi Ricardo, On Fri, Oct 01, 2021 at 11:25:17AM +0000, Ricardo Ribalda wrote: > The initial format did not have a valid size. > > Fixes v4l2-compliance: > > fail: v4l2-test-formats.cpp(723): Video Output Multiplanar: > TRY_FMT(G_FMT) != G_FMT > test VIDIOC_TRY_FMT: FAIL > > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx> > --- > drivers/staging/media/ipu3/ipu3-v4l2.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c > index 38a2407645096..1813bb29e362b 100644 > --- a/drivers/staging/media/ipu3/ipu3-v4l2.c > +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c > @@ -1136,7 +1136,9 @@ static int imgu_v4l2_node_setup(struct imgu_device *imgu, unsigned int pipe, > def_pix_fmt.height = def_bus_fmt.height; > def_pix_fmt.field = def_bus_fmt.field; > def_pix_fmt.num_planes = 1; > - def_pix_fmt.plane_fmt[0].bytesperline = def_pix_fmt.width * 2; > + def_pix_fmt.plane_fmt[0].bytesperline = > + imgu_bytesperline(def_pix_fmt.width, > + IMGU_ABI_FRAME_FORMAT_RAW_PACKED); I thought this was for the CIO2 driver when reviewing it, because of the subject at the time. ;-) The 2nd patch is very nice, thanks! -- Sakari Ailus
