Hi David, Laurent,
On Wed, Oct 06, 2021 at 04:10:26AM +0300, Laurent Pinchart wrote:
> Hi David,
>
> On Tue, Oct 05, 2021 at 10:37:54AM +0100, David Plowman wrote:
> > Hi Laurent, Sakari, everyone
> >
> > I was wondering whether I might give this another little nudge just so
> > that it doesn't get lost.
>
> I've already reviewed it, I can only join you to nicely ask Sakari if he
> could have a look :-) I know he has lots of patches on his plate at the
> moment though.
>
> Hans, would you like to share your opinion on this series ?
The patches have been merged some time ago to the media tree master branch:
commit 311a839a1ad255ebcb7291fb4e0d2ec2f32312a7
Author: David Plowman <david.plowman@xxxxxxxxxxxxxxx>
Date: Mon Aug 16 13:39:09 2021 +0200
media: v4l2-ctrls: Document V4L2_CID_NOTIFY_GAINS control
Add documentation for the V4L2_CID_NOTIFY_GAINS control.
This control is required by sensors that need to know what colour
gains will be applied to pixels by downstream processing (such as by
an ISP), though the sensor does not apply these gains itself.
Signed-off-by: David Plowman <david.plowman@xxxxxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
commit a9c80593ff80ddb7c6496624e5384e1ea3460a72
Author: David Plowman <david.plowman@xxxxxxxxxxxxxxx>
Date: Mon Aug 16 13:39:08 2021 +0200
media: v4l2-ctrls: Add V4L2_CID_NOTIFY_GAINS control
We add a new control V4L2_CID_NOTIFY_GAINS which allows the sensor to
be notified what gains will be applied to the different colour
channels by subsequent processing (such as by an ISP), even though the
sensor will not apply any of these gains itself.
For Bayer sensors this will be an array control taking 4 values which
are the 4 gains arranged in the fixed order B, Gb, Gr and R,
irrespective of the exact Bayer order of the sensor itself. The use of
an array makes it straightforward to extend this control to non-Bayer
sensors (for example, sensors with an RGBW pattern) in future.
The units are in all cases linear with the default value indicating a
gain of exactly 1.0. For example, if the default value were reported as
128 then the value 192 would represent a gain of exactly 1.5.
Signed-off-by: David Plowman <david.plowman@xxxxxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
--
Kind regards,
Sakari Ailus
