On Thu, 23 Sep 2021 16:37:31 +0200, Philipp Zabel wrote: > On Thu, 2021-09-23 at 12:56 +0200, Michael Tretter wrote: > > Step 5 expects that the sensor is in LP11 mode. Use the new > > pre_streamon callback to signal the sensor that it should switch into > > LP11. > > > > Signed-off-by: Michael Tretter <m.tretter@xxxxxxxxxxxxxx> > > --- > > Changelog: > > > > v4: > > > > - new patch > > --- > > drivers/staging/media/imx/imx6-mipi-csi2.c | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/media/imx/imx6-mipi-csi2.c b/drivers/staging/media/imx/imx6-mipi-csi2.c > > index 9de0ebd439dc..4f19e2bce4bb 100644 > > --- a/drivers/staging/media/imx/imx6-mipi-csi2.c > > +++ b/drivers/staging/media/imx/imx6-mipi-csi2.c > > @@ -382,13 +382,17 @@ static int csi2_start(struct csi2_dev *csi2) > > csi2_enable(csi2, true); > > > > /* Step 5 */ > > + ret = v4l2_subdev_call(csi2->src_sd, video, pre_streamon, > > + V4L2_SUBDEV_PRE_STREAMON_FL_MANUAL_LP); > > + if (ret) > > + goto err_assert_reset; > > I think this should check for (ret && ret != -ENOIOCTLCMD) to avoid > breaking drivers that are still missing pre_streamon implementation. Thanks. You are correct. I will wait for further comments on the other patches of the series and fix it in the next version. Michael
