hex_block should not return without printing a newline (which occurs when the length is zero). This causes a missing newline after "Application Version: 1" with cta_hdr10plus for an EDID I have.
Any place that calls hex_block will have the same problem if it's possible for the length to be zero.
In other words, a hex_block needs to have a linefeed even if it has zero length, because the caller assumes it will go to the next line as it does when the hex block is not zero length.
Signed-off-by: Joe van Tunen <joevt@xxxxxxx>
---
edid-decode.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/edid-decode.cpp b/edid-decode.cpp
index 2316abc..6aa93fb 100644
--- a/edid-decode.cpp
+++ b/edid-decode.cpp
@@ -698,8 +698,10 @@ void hex_block(const char *prefix, const unsigned char *x,
{
unsigned i, j;
- if (!length)
+ if (!length) {
+ printf("\n");
return;
+ }
for (i = 0; i < length; i += step) {
unsigned len = min(step, length - i);
--
2.24.3 (Apple Git-128)
