Em 30-05-2010 09:19, stefan.ringel@xxxxxxxx escreveu: > From: Stefan Ringel <stefan.ringel@xxxxxxxx> > > move debug info print from header into c file I don't see why to duplicate the printk's on every file. It seems better to me to just keep them at the header file, and use tm6000_debug symbol for every tm6000 module. Btw, I've applied a CodingStyle fix patch on my tree, together with the other patches. As it touches on almost all drivers, it is better to merge from my tree ASAP. I dunno why, but your rewrite copy_streams didn't apply fine, but this time I've fixed the issues manually. I tested it here with two cards (Saphire Wonder TV - a 10moons clone, based on tm5600 - and HVR900H), and the merge worked fine. With your patch, image seems to be working fine (yet, I didn't re-add the memset(0) to double check). However, running on a remote machine, via fast ethernet, the buffering effect is seeing. Probably, there's still some trouble at the routine that fills the buffers. - I suggest that you and Dmitri to use staging/tm6000 branch for development. this will likely help to avoid conflict issues. As usual, before submitting a patch, it would be wise to rebase it against upstream with: git remote update git pull . staging/tm6000 git rebase staging/tm6000 After doing it, please compile and test, before submitting me the patches. Cheers, Mauro. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
