Hi Pedro, Your 'From' email is Pedro Terra <pedro@xxxxxxxxxx>, but... On 31/08/2021 19:48, Pedro Terra wrote: > Modify the scaler subdevice to accept setting the resolution of the source > pad (previously the source resolution would always be 3 times the sink for > both dimensions). Now any resolution can be set at src (even smaller ones) > and the sink video will be scaled to match it. > > Test example: With the vimc module up (using the default vimc topology) > media-ctl -d platform:vimc -V '"Sensor A":0[fmt:SBGGR8_1X8/640x480]' > media-ctl -d platform:vimc -V '"Debayer A":0[fmt:SBGGR8_1X8/640x480]' > media-ctl -d platform:vimc -V '"Scaler":0[fmt:RGB888_1X24/640x480]' > media-ctl -d platform:vimc -V '"Scaler":0[crop:(100,50)/400x150]' > media-ctl -d platform:vimc -V '"Scaler":1[fmt:RGB888_1X24/300x700]' > v4l2-ctl -z platform:vimc -d "RGB/YUV Capture" -v width=300,height=700 > v4l2-ctl -z platform:vimc -d "Raw Capture 0" -v pixelformat=BA81 > v4l2-ctl --stream-mmap --stream-count=10 -z platform:vimc -d "RGB/YUV Capture" \ > -stream-to=test.raw > > The result will be a cropped stream that can be checked with the command > ffplay -loglevel warning -v info -f rawvideo -pixel_format rgb24 \ > -video_size "300x700" test.raw > > Co-developed-by: Gabriela Bittencourt <gabrielabittencourt00@xxxxxxxxx> > Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@xxxxxxxxx> > Co-developed-by: Gabriel Francisco Mandaji <gfmandaji@xxxxxxxxx> > Signed-off-by: Gabriel Francisco Mandaji <gfmandaji@xxxxxxxxx> > Signed-off-by: Pedro "pirate" Terra <pirate@xxxxxxxxxx> ... that differs from what is used in this Signed-off-by. checkpatch.pl complains about that. Which of the two should I use? I can fix it myself in the pull request, but I need to know which one I should use. For future patches, please use consistent email addresses. Regards, Hans
