Re: Soc-camera and 2.6.33

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 1 Jun 2010, Robert Jarzmik wrote:

> Guennadi Liakhovetski <g.liakhovetski@xxxxxx> writes:
> 
> > a lot of things changed in and around soc-camera between 2.6.30 and 
> > .33... E.g., previously you could load driver modules in any order, it 
> > would work in any case. Now if you load your host driver (pxa) and your 
> > client driver is not there yet, it should be automatically loaded. 
> > However, if your user-space doesn't support this, it won't work. Can this 
> > be the reason gor your problem? Otherwise, I'd suspect a problem with your 
> > platform data (cf. other platforms), or, eventually with mt9m111.
> 
> I tracked down the beast ... :)
> 
> The problem is with the commit a48c24a696f0d93c49f913b7818e9819612b1f4e
> "[ARM] pxa/mioa701: convert mioa701 to the new platform-device soc-camera
> interface".

hm, I would humbly disagree - the "__initdata" was there before that 
commit. With my conversion I just missed it and noone tested it since 
then;)
> 
> This is a tricky one ... :
>   - ic_link is declared normally, and references &mioa701_i2c_devices[0]
>   - but mioa701_i2c_devices[] is declared as __initdata, and discarded after
>   init if I understand correctly.
> 
> This implies that the structure ic_link references something not present
> anymore, hence my bug.

Nice catch!

> I'm a bit disturbed that the compiler didn't catch that
> ...

Interesting...

> Anyway, now I'll have to send a patch to Eric for that, to remove the
> "__initdata" specifier from mioa701_i2c_devices[].
> 
> Eric, are you still taking in fix patches for the 2.6.35 kernel ?

Of course, bugfixes must be taken at any time.

> PS: I checked for other pxa boards, and they don't suffer from my problem.

And not only PXA.

Thanks for debugging!
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux