Re: [PATCH v3] media: vivid: drop FB dependency with new VIDEO_VIVID_FB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guillaume,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.14]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Guillaume-Tucker/media-vivid-drop-FB-dependency-with-new-VIDEO_VIVID_FB/20210903-232914
base:   git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-r001-20210906 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/d730c581d478b1bddea0e3d6c0884f54487330ff
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Guillaume-Tucker/media-vivid-drop-FB-dependency-with-new-VIDEO_VIVID_FB/20210903-232914
        git checkout d730c581d478b1bddea0e3d6c0884f54487330ff
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   ld: drivers/media/test-drivers/vivid/vivid-core.o: in function `vivid_remove':
>> drivers/media/test-drivers/vivid/vivid-core.c:2083: undefined reference to `unregister_framebuffer'
   ld: drivers/media/test-drivers/vivid/vivid-osd.o: in function `vivid_fb_release_buffers':
>> drivers/media/test-drivers/vivid/vivid-osd.c:346: undefined reference to `fb_dealloc_cmap'
   ld: drivers/media/test-drivers/vivid/vivid-osd.o: in function `vivid_fb_init_vidmode':
>> drivers/media/test-drivers/vivid/vivid-osd.c:327: undefined reference to `fb_alloc_cmap'
   ld: drivers/media/test-drivers/vivid/vivid-osd.o: in function `vivid_fb_init':
>> drivers/media/test-drivers/vivid/vivid-osd.c:379: undefined reference to `register_framebuffer'
>> ld: drivers/media/test-drivers/vivid/vivid-osd.o:(.rodata+0x78): undefined reference to `cfb_fillrect'
>> ld: drivers/media/test-drivers/vivid/vivid-osd.o:(.rodata+0x80): undefined reference to `cfb_copyarea'
>> ld: drivers/media/test-drivers/vivid/vivid-osd.o:(.rodata+0x88): undefined reference to `cfb_imageblit'


vim +2083 drivers/media/test-drivers/vivid/vivid-core.c

945b07b1630fd1 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2018-05-21  2043  
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2044  		if (dev->has_vid_cap) {
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2045  			v4l2_info(&dev->v4l2_dev, "unregistering %s\n",
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2046  				video_device_node_name(&dev->vid_cap_dev));
bda24f433013d6 drivers/media/test-drivers/vivid/vivid-core.c Hans Verkuil     2020-07-13  2047  			vb2_video_unregister_device(&dev->vid_cap_dev);
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2048  		}
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2049  		if (dev->has_vid_out) {
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2050  			v4l2_info(&dev->v4l2_dev, "unregistering %s\n",
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2051  				video_device_node_name(&dev->vid_out_dev));
bda24f433013d6 drivers/media/test-drivers/vivid/vivid-core.c Hans Verkuil     2020-07-13  2052  			vb2_video_unregister_device(&dev->vid_out_dev);
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2053  		}
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2054  		if (dev->has_vbi_cap) {
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2055  			v4l2_info(&dev->v4l2_dev, "unregistering %s\n",
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2056  				video_device_node_name(&dev->vbi_cap_dev));
bda24f433013d6 drivers/media/test-drivers/vivid/vivid-core.c Hans Verkuil     2020-07-13  2057  			vb2_video_unregister_device(&dev->vbi_cap_dev);
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2058  		}
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2059  		if (dev->has_vbi_out) {
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2060  			v4l2_info(&dev->v4l2_dev, "unregistering %s\n",
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2061  				video_device_node_name(&dev->vbi_out_dev));
bda24f433013d6 drivers/media/test-drivers/vivid/vivid-core.c Hans Verkuil     2020-07-13  2062  			vb2_video_unregister_device(&dev->vbi_out_dev);
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2063  		}
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2064  		if (dev->has_sdr_cap) {
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2065  			v4l2_info(&dev->v4l2_dev, "unregistering %s\n",
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2066  				video_device_node_name(&dev->sdr_cap_dev));
bda24f433013d6 drivers/media/test-drivers/vivid/vivid-core.c Hans Verkuil     2020-07-13  2067  			vb2_video_unregister_device(&dev->sdr_cap_dev);
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2068  		}
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2069  		if (dev->has_radio_rx) {
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2070  			v4l2_info(&dev->v4l2_dev, "unregistering %s\n",
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2071  				video_device_node_name(&dev->radio_rx_dev));
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2072  			video_unregister_device(&dev->radio_rx_dev);
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2073  		}
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2074  		if (dev->has_radio_tx) {
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2075  			v4l2_info(&dev->v4l2_dev, "unregistering %s\n",
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2076  				video_device_node_name(&dev->radio_tx_dev));
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2077  			video_unregister_device(&dev->radio_tx_dev);
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2078  		}
d730c581d478b1 drivers/media/test-drivers/vivid/vivid-core.c Guillaume Tucker 2021-09-03  2079  #if IS_ENABLED(CONFIG_VIDEO_VIVID_FB)
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2080  		if (dev->has_fb) {
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2081  			v4l2_info(&dev->v4l2_dev, "unregistering fb%d\n",
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2082  				dev->fb_info.node);
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25 @2083  			unregister_framebuffer(&dev->fb_info);
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2084  			vivid_fb_release_buffers(dev);
d5797cf685a0a3 drivers/media/platform/vivid/vivid-core.c     Vandana BN       2019-10-15  2085  		}
d730c581d478b1 drivers/media/test-drivers/vivid/vivid-core.c Guillaume Tucker 2021-09-03  2086  #endif
d5797cf685a0a3 drivers/media/platform/vivid/vivid-core.c     Vandana BN       2019-10-15  2087  		if (dev->has_meta_cap) {
d5797cf685a0a3 drivers/media/platform/vivid/vivid-core.c     Vandana BN       2019-10-15  2088  			v4l2_info(&dev->v4l2_dev, "unregistering %s\n",
d5797cf685a0a3 drivers/media/platform/vivid/vivid-core.c     Vandana BN       2019-10-15  2089  				  video_device_node_name(&dev->meta_cap_dev));
bda24f433013d6 drivers/media/test-drivers/vivid/vivid-core.c Hans Verkuil     2020-07-13  2090  			vb2_video_unregister_device(&dev->meta_cap_dev);
746facd39370cc drivers/media/platform/vivid/vivid-core.c     Vandana BN       2019-10-15  2091  		}
746facd39370cc drivers/media/platform/vivid/vivid-core.c     Vandana BN       2019-10-15  2092  		if (dev->has_meta_out) {
746facd39370cc drivers/media/platform/vivid/vivid-core.c     Vandana BN       2019-10-15  2093  			v4l2_info(&dev->v4l2_dev, "unregistering %s\n",
746facd39370cc drivers/media/platform/vivid/vivid-core.c     Vandana BN       2019-10-15  2094  				  video_device_node_name(&dev->meta_out_dev));
bda24f433013d6 drivers/media/test-drivers/vivid/vivid-core.c Hans Verkuil     2020-07-13  2095  			vb2_video_unregister_device(&dev->meta_out_dev);
3d15c7643ba78b drivers/media/platform/vivid/vivid-core.c     Vandana BN       2019-11-26  2096  		}
3d15c7643ba78b drivers/media/platform/vivid/vivid-core.c     Vandana BN       2019-11-26  2097  		if (dev->has_touch_cap) {
3d15c7643ba78b drivers/media/platform/vivid/vivid-core.c     Vandana BN       2019-11-26  2098  			v4l2_info(&dev->v4l2_dev, "unregistering %s\n",
3d15c7643ba78b drivers/media/platform/vivid/vivid-core.c     Vandana BN       2019-11-26  2099  				  video_device_node_name(&dev->touch_cap_dev));
bda24f433013d6 drivers/media/test-drivers/vivid/vivid-core.c Hans Verkuil     2020-07-13  2100  			vb2_video_unregister_device(&dev->touch_cap_dev);
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2101  		}
6f8adea2b64f7e drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2016-02-05  2102  		cec_unregister_adapter(dev->cec_rx_adap);
6f8adea2b64f7e drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2016-02-05  2103  		for (j = 0; j < MAX_OUTPUTS; j++)
6f8adea2b64f7e drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2016-02-05  2104  			cec_unregister_adapter(dev->cec_tx_adap[j]);
6f8adea2b64f7e drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2016-02-05  2105  		if (dev->cec_workqueue) {
6f8adea2b64f7e drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2016-02-05  2106  			vivid_cec_bus_free_work(dev);
6f8adea2b64f7e drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2016-02-05  2107  			destroy_workqueue(dev->cec_workqueue);
6f8adea2b64f7e drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2016-02-05  2108  		}
87c674e24362cf drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2015-03-13  2109  		v4l2_device_put(&dev->v4l2_dev);
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2110  		vivid_devs[i] = NULL;
c88a96b023d823 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2014-08-25  2111  	}
f46d740fb02589 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2015-03-13  2112  	return 0;
f46d740fb02589 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2015-03-13  2113  }
f46d740fb02589 drivers/media/platform/vivid/vivid-core.c     Hans Verkuil     2015-03-13  2114  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux