I am getting the following compilation error on ubuntu 20.04 with gcc 9.3.0. drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function ‘input_system_configure_channel_sensor’: drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type] 1649 | } | ^ cc1: some warnings being treated as errors make[4]: *** [scripts/Makefile.build:277: drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.o] Error 1 I made some minor changes to the switch-case to keep gcc happy. Signed-off-by: Tong Zhang <ztong0001@xxxxxxxxx> --- .../media/atomisp/pci/hive_isp_css_common/host/input_system.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c index 8e085dda0c18..58eb74edc953 100644 --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c @@ -1644,8 +1644,9 @@ static input_system_err_t input_system_configure_channel_sensor( case INPUT_SYSTEM_XMEM_CAPTURE: case INPUT_SYSTEM_XMEM_ACQUIRE: default: - return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; + break; } + return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED; } // Test flags and set structure. -- 2.25.1