Re: [PATCH 4/8] staging: media: zoran: add debugfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Corentin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Corentin-Labbe/staging-media-zoran-fusion-in-one-module/20210904-031844
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 5d7d11dead3ea7191a8e8635fb718d0c3f203fe0
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1e16912d8cd1602ddb54f3e43e17021b8daf4e58
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Corentin-Labbe/staging-media-zoran-fusion-in-one-module/20210904-031844
        git checkout 1e16912d8cd1602ddb54f3e43e17021b8daf4e58
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   drivers/staging/media/zoran/zoran_card.c: In function 'zoran_debugfs_show':
>> drivers/staging/media/zoran/zoran_card.c:1061:32: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'v4l2_std_id' {aka 'long long unsigned int'} [-Wformat=]
    1061 |         seq_printf(seq, "Norm %x\n", zr->norm);
         |                               ~^     ~~~~~~~~
         |                                |       |
         |                                |       v4l2_std_id {aka long long unsigned int}
         |                                unsigned int
         |                               %llx


vim +1061 drivers/staging/media/zoran/zoran_card.c

  1053	
  1054	#ifdef CONFIG_VIDEO_ZORAN_DEBUG
  1055	static int zoran_debugfs_show(struct seq_file *seq, void *v)
  1056	{
  1057		struct zoran *zr = seq->private;
  1058	
  1059		seq_printf(seq, "Running mode %x\n", zr->running);
  1060		seq_printf(seq, "Codec mode %x\n", zr->codec_mode);
> 1061		seq_printf(seq, "Norm %x\n", zr->norm);
  1062		seq_printf(seq, "Input %d\n", zr->input);
  1063		seq_printf(seq, "Buffersize %d\n", zr->buffer_size);
  1064	
  1065		seq_printf(seq, "V4L width %dx%d\n", zr->v4l_settings.width, zr->v4l_settings.height);
  1066		seq_printf(seq, "V4L bytesperline %d\n", zr->v4l_settings.bytesperline);
  1067	
  1068		seq_printf(seq, "JPG decimation %u\n", zr->jpg_settings.decimation);
  1069		seq_printf(seq, "JPG hor_dcm %u\n", zr->jpg_settings.hor_dcm);
  1070		seq_printf(seq, "JPG ver_dcm %u\n", zr->jpg_settings.ver_dcm);
  1071		seq_printf(seq, "JPG tmp_dcm %u\n", zr->jpg_settings.tmp_dcm);
  1072		seq_printf(seq, "JPG odd_even %u\n", zr->jpg_settings.odd_even);
  1073		seq_printf(seq, "JPG crop %dx%d %d %d\n",
  1074			zr->jpg_settings.img_x,
  1075			zr->jpg_settings.img_y,
  1076			zr->jpg_settings.img_width,
  1077			zr->jpg_settings.img_height);
  1078	
  1079		seq_printf(seq, "Prepared %u\n", zr->prepared);
  1080		seq_printf(seq, "Queued %u\n", zr->queued);
  1081		return 0;
  1082	}
  1083	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux