On 02/09/2021 13:10, Dongliang Mu wrote: > On Thu, Sep 2, 2021 at 6:59 PM Dongliang Mu <mudongliangabcd@xxxxxxxxx> wrote: >> >> On Thu, Sep 2, 2021 at 6:54 PM Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> wrote: >>> >>> Em Thu, 2 Sep 2021 12:39:37 +0200 >>> Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> escreveu: >>> >>>> On Thu, Sep 02, 2021 at 06:23:36PM +0800, Dongliang Mu wrote: >>>>> On Fri, Jul 23, 2021 at 6:11 PM Dongliang Mu <mudongliangabcd@xxxxxxxxx> wrote: >>>>>> >>>>>> On Wed, Jul 14, 2021 at 11:23 AM Dongliang Mu <mudongliangabcd@xxxxxxxxx> wrote: >>>>>>> >>>>>>> stk_camera_probe mistakenly execute usb_get_intf and increase the >>>>>>> refcount of interface->dev. >>>>>>> >>>>>>> Fix this by removing the execution of usb_get_intf. >>>>>> >>>>>> Any idea about this patch? >>>>> >>>>> +cc Dan Carpenter, gregkh >>>>> >>>>> There is no reply in this thread in one month. Can someone give some >>>>> feedback on this patch? >>>> >>>> This is the media developers domain, not much I can do here. >>> >>> There is a high volume of patches for the media subsystem. Anyway, >>> as your patch is at our patchwork instance: >>> >>> https://patchwork.linuxtv.org/project/linux-media/patch/20210714032340.504836-1-mudongliangabcd@xxxxxxxxx/ >>> >>> It should be properly tracked, and likely handled after the end of >>> the merge window. > > Hi Mauro, > > I found there is another fix [1] for the same memory leak from Pavel > Skripkin (already cc-ed in this thread). > > [1] https://www.spinics.net/lists/stable/msg479628.html Ah, that's why I marked it as Obsoleted :-) Regards, Hans > >>> >>>>>>> Reported-by: Dongliang Mu <mudongliangabcd@xxxxxxxxx> >>>>>>> Fixes: 0aa77f6c2954 ("[media] move the remaining USB drivers to drivers/media/usb") >>>>>>> Signed-off-by: Dongliang Mu <mudongliangabcd@xxxxxxxxx> >>> >>> If you're the author of the patch, it doesn't make much sense to >>> add a "Reported-by:" tag there. We only use it in order to give >>> someone's else credit to report an issue. >> >> I see. Someone told me this rule in another thread. I will update this >> in the next version. >> >>> >>> Thanks, >>> Mauro