Hi Arec, On Thu, Aug 12, 2021 at 03:38:55AM +0000, Kao, Arec wrote: > Hi Sakari, > > Thank you for the nice feedback. I will fix each of your comments on v2 > patch. As regards to your comment: "Does v/hflip change the pixel order > with this driver btw.?", yes, it does actually change bayer order when > image flip/mirror and already made some changes with > increasing/decreasing horizontal/ vertical window offset in v/hflip > function. Ok. Almost all sensors require changing the Bayer order but some drivers just shift the crop window by one pixel. Either is fine, as long as it is taken care of so that the sensor produces pixels in the order the driver indicates. -- Regards, Sakari Ailus
