On Monday 24 May 2010 14:21:41 Matti J. Aaltonen wrote:
> This is a parent driver for two child drivers: the V4L2 driver and
> the ALSA codec driver. The MFD part provides the I2C communication
> to the device and a couple of functions that are called from both
> children.
>
> Signed-off-by: Matti J. Aaltonen <matti.j.aaltonen@xxxxxxxxx>
> ---
> drivers/mfd/Kconfig | 6 +
> drivers/mfd/Makefile | 2 +
> drivers/mfd/wl1273-core.c | 606 +++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/wl1273-core.h | 326 +++++++++++++++++++++
> 4 files changed, 940 insertions(+), 0 deletions(-)
> create mode 100644 drivers/mfd/wl1273-core.c
> create mode 100644 include/linux/mfd/wl1273-core.h
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 413576a..5998a94 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -135,6 +135,12 @@ config TWL4030_CODEC
> select MFD_CORE
> default n
>
> +config WL1273_CORE
> + bool
> + depends on I2C
> + select MFD_CORE
> + default n
> +
> config MFD_TMIO
> bool
> default n
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 78295d6..46e611d 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -30,6 +30,8 @@ obj-$(CONFIG_TWL4030_CORE) += twl-core.o twl4030-irq.o twl6030-irq.o
> obj-$(CONFIG_TWL4030_POWER) += twl4030-power.o
> obj-$(CONFIG_TWL4030_CODEC) += twl4030-codec.o
>
> +obj-$(CONFIG_WL1273_CORE) += wl1273-core.o
> +
> obj-$(CONFIG_MFD_MC13783) += mc13783-core.o
>
> obj-$(CONFIG_MFD_CORE) += mfd-core.o
> diff --git a/drivers/mfd/wl1273-core.c b/drivers/mfd/wl1273-core.c
> new file mode 100644
> index 0000000..7e02c36
> --- /dev/null
> +++ b/drivers/mfd/wl1273-core.c
> @@ -0,0 +1,606 @@
> +/*
> + * MFD driver for wl1273 FM radio and audio codec submodules.
> + *
> + * Author: Matti Aaltonen <matti.j.aaltonen@xxxxxxxxx>
> + *
> + * Copyright: (C) 2010 Nokia Corporation
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
> + * 02110-1301 USA
> + *
> + */
> +
> +#undef DEBUG
> +
> +#include <asm/unaligned.h>
> +#include <linux/completion.h>
> +#include <linux/delay.h>
> +#include <linux/i2c.h>
> +#include <linux/interrupt.h>
> +#include <linux/module.h>
> +#include <linux/types.h>
> +#include <linux/kernel.h>
> +#include <linux/fs.h>
> +#include <linux/platform_device.h>
> +#include <linux/mfd/core.h>
> +#include <linux/mfd/wl1273-core.h>
> +#include <media/v4l2-common.h>
> +
> +#define DRIVER_DESC "WL1273 FM Radio Core"
> +
> +#define WL1273_IRQ_MASK (WL1273_FR_EVENT | \
> + WL1273_POW_ENB_EVENT)
> +
> +static const struct band_info bands[] = {
> + /* Japan */
> + {
> + .bottom_frequency = 76000,
> + .top_frequency = 90000,
> + .band = 0,
> + },
> + /* USA & Europe */
> + {
> + .bottom_frequency = 87500,
> + .top_frequency = 108000,
> + .band = 1,
> + },
> +};
> +
> +/*
> + * static unsigned char radio_band - Band
> + *
> + * The bands are 0=Japan, 1=USA-Europe. USA-Europe is the default.
> + */
> +static unsigned char radio_band = 1;
> +module_param(radio_band, byte, 0);
> +MODULE_PARM_DESC(radio_band, "Band: 0=Japan, 1=USA-Europe*");
> +
> +/*
> + * static unsigned int rds_buf - the number of RDS buffer blocks used.
> + *
> + * The default number is 100.
> + */
> +static unsigned int rds_buf = 100;
> +module_param(rds_buf, uint, 0);
> +MODULE_PARM_DESC(rds_buf, "RDS buffer entries: *100*");
> +
> +int wl1273_fm_read_reg(struct wl1273_core *core, u8 reg, u16 *value)
> +{
> + struct i2c_client *client = core->i2c_dev;
> + u8 b[2];
> + int r;
> +
> + r = i2c_smbus_read_i2c_block_data(client, reg, 2, b);
> + if (r != 2) {
> + dev_err(&client->dev, "%s: Read: %d fails.\n", __func__, reg);
> + return -EREMOTEIO;
> + }
> +
> + *value = (u16)b[0] << 8 | b[1];
> +
> + return 0;
> +}
> +EXPORT_SYMBOL(wl1273_fm_read_reg);
> +
> +int wl1273_fm_write_cmd(struct wl1273_core *core, u8 cmd, u16 param)
> +{
> + struct i2c_client *client = core->i2c_dev;
> + u8 buf[] = { (param >> 8) & 0xff, param & 0xff };
> + int r;
> +
> + r = i2c_smbus_write_i2c_block_data(client, cmd, 2, buf);
> + if (r) {
> + dev_err(&client->dev, "%s: Cmd: %d fails.\n", __func__, cmd);
> + return r;
> + }
> +
> + return 0;
> +}
> +EXPORT_SYMBOL(wl1273_fm_write_cmd);
> +
> +int wl1273_fm_write_data(struct wl1273_core *core, u8 *data, u16 len)
> +{
> + struct i2c_client *client = core->i2c_dev;
> + struct i2c_msg msg[1];
> + int r;
> +
> + msg[0].addr = client->addr;
> + msg[0].flags = 0;
> + msg[0].buf = data;
> + msg[0].len = len;
> +
> + r = i2c_transfer(client->adapter, msg, 1);
> +
> + if (r != 1) {
> + dev_err(&client->dev, "%s: write error.\n", __func__);
> + return -EREMOTEIO;
> + }
> +
> + return 0;
> +}
> +EXPORT_SYMBOL(wl1273_fm_write_data);
> +
> +/**
> + * wl1273_fm_set_audio() - Set audio mode.
> + * @core: A pointer to the device struct.
> + * @new_mode: The new audio mode.
> + *
> + * Audio modes are WL1273_AUDIO_DIGITAL and WL1273_AUDIO_ANALOG.
> + */
> +int wl1273_fm_set_audio(struct wl1273_core *core, unsigned int new_mode)
> +{
> + int r = 0;
> +
> + if (core->mode == WL1273_MODE_OFF ||
> + core->mode == WL1273_MODE_SUSPENDED)
> + return -EPERM;
> +
> + if (core->mode == WL1273_MODE_RX && new_mode == WL1273_AUDIO_DIGITAL) {
> + r = wl1273_fm_write_cmd(core, WL1273_PCM_MODE_SET,
> + WL1273_PCM_DEF_MODE);
> + if (r)
> + goto out;
> +
> + r = wl1273_fm_write_cmd(core, WL1273_I2S_MODE_CONFIG_SET,
> + core->i2s_mode);
> + if (r)
> + goto out;
> +
> + r = wl1273_fm_write_cmd(core, WL1273_AUDIO_ENABLE,
> + WL1273_AUDIO_ENABLE_I2S);
> + if (r)
> + goto out;
> +
> + } else if (core->mode == WL1273_MODE_RX &&
> + new_mode == WL1273_AUDIO_ANALOG) {
> + r = wl1273_fm_write_cmd(core, WL1273_AUDIO_ENABLE,
> + WL1273_AUDIO_ENABLE_ANALOG);
> + if (r)
> + goto out;
> +
> + } else if (core->mode == WL1273_MODE_TX &&
> + new_mode == WL1273_AUDIO_DIGITAL) {
> + r = wl1273_fm_write_cmd(core, WL1273_I2S_MODE_CONFIG_SET,
> + core->i2s_mode);
> + if (r)
> + goto out;
> +
> + r = wl1273_fm_write_cmd(core, WL1273_AUDIO_IO_SET,
> + WL1273_AUDIO_IO_SET_I2S);
> + if (r)
> + goto out;
> +
> + } else if (core->mode == WL1273_MODE_TX &&
> + new_mode == WL1273_AUDIO_ANALOG) {
> + r = wl1273_fm_write_cmd(core, WL1273_AUDIO_IO_SET,
> + WL1273_AUDIO_IO_SET_ANALOG);
> + if (r)
> + goto out;
> + }
> +
> + core->audio_mode = new_mode;
> +
> +out:
> + return r;
> +}
> +EXPORT_SYMBOL(wl1273_fm_set_audio);
> +
> +/**
> + * wl1273_fm_set_volume() - Set volume.
> + * @core: A pointer to the device struct.
> + * @volume: The new volume value.
> + */
> +int wl1273_fm_set_volume(struct wl1273_core *core, unsigned int volume)
> +{
> + u16 val;
> + int r;
> +
> + if (volume > WL1273_MAX_VOLUME)
> + return -EINVAL;
> +
> + if (core->volume == volume)
> + return 0;
> +
> + val = volume;
> + r = wl1273_fm_read_reg(core, WL1273_VOLUME_SET, &val);
> + if (r)
> + return r;
> +
> + core->volume = volume;
> + return 0;
> +}
> +EXPORT_SYMBOL(wl1273_fm_set_volume);
> +
> +static int wl1273_fm_rds(struct wl1273_core *core)
> +{
> + struct i2c_client *client = core->i2c_dev;
> + struct device *dev = &client->dev;
> + struct rds_status {
> + unsigned int block_id:3;
> + unsigned int error_status:2;
> + unsigned int fifo_status:1;
> + unsigned int frame_in_sync:1;
> + unsigned int spare:1;
Don't use bitfields! How bitfields are ordered is compiler specific.
> + } rsta;
> + u16 val;
> + u8 b0[] = { WL1273_RDS_DATA_GET };
> + u8 b1[] = { 0, 0, 0 };
> + struct i2c_msg msg[] = {
> + {
> + .addr = client->addr,
> + .flags = 0,
> + .buf = b0,
> + .len = 1
> + },
> + {
> + .addr = client->addr,
> + .flags = I2C_M_RD,
> + .buf = b1,
> + .len = 3
> + }
> + };
> + int r;
> +
> + r = wl1273_fm_read_reg(core, WL1273_RDS_SYNC_GET, &val);
> + if (r)
> + return r;
> +
> + if ((val & 0x01) == 0) {
> + /* RDS decoder not synchronized */
> + return -EAGAIN;
> + }
> +
> + /* copy all four RDS blocks to internal buffer */
> + do {
> + r = i2c_transfer(client->adapter, msg, 2);
> + if (r != 2) {
> + dev_err(dev, WL1273_FM_DRIVER_NAME
> + ": %s: read_rds error r == %i)\n",
> + __func__, r);
> + }
> +
> + rsta = *(struct rds_status *) &b1[2];
> + if (rsta.fifo_status == 0)
> + break;
> +
> + /* copy RDS block to internal buffer */
> + memcpy(&core->buffer[core->wr_index], &b1, 3);
> + core->wr_index += 3;
Does the data you copy here conform to the v4l2_rds_data struct?
In particular the block byte. It is well documented in the Spec in the
section on 'Reading RDS data'.
> +
> + /* wrap write pointer */
> + if (core->wr_index >= core->buf_size)
> + core->wr_index = 0;
> +
> + /* check for overflow & start over */
> + if (core->wr_index == core->rd_index) {
> + dev_dbg(dev, "RDS OVERFLOW");
> +
> + core->rd_index = 0;
> + core->wr_index = 0;
> + break;
> + }
> + } while (rsta.fifo_status == 1);
> +
> + /* wake up read queue */
> + if (core->wr_index != core->rd_index)
> + wake_up_interruptible(&core->read_queue);
> +
> + return 0;
> +}
Regards,
Hans
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
