Re: [PATCH] dma_heap: enable map_attrs when (un)map_attachment

[kernel test robot <lkp@xxxxxxxxx>]

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.14-rc5 next-20210809]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/guangming-cao-mediatek-com/dma_heap-enable-map_attrs-when-un-map_attachment/20210810-100452
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 9a73fa375d58fee5262dd16473c8e7522bdf44de
config: alpha-buildonly-randconfig-r003-20210809 (attached as .config)
compiler: alpha-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/b1a5626566cf9a73b35a742151246017ac87556b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review guangming-cao-mediatek-com/dma_heap-enable-map_attrs-when-un-map_attachment/20210810-100452
        git checkout b1a5626566cf9a73b35a742151246017ac87556b
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/dma-buf/heaps/system_heap.c: In function 'system_heap_map_dma_buf':
>> drivers/dma-buf/heaps/system_heap.c:133:24: error: 'struct dma_buf_attachment' has no member named 'dma_map_attrs'
     133 |  int attrs = attachment->dma_map_attrs;
         |                        ^~
   drivers/dma-buf/heaps/system_heap.c: In function 'system_heap_unmap_dma_buf':
   drivers/dma-buf/heaps/system_heap.c:149:24: error: 'struct dma_buf_attachment' has no member named 'dma_map_attrs'
     149 |  int attrs = attachment->dma_map_attrs;
         |                        ^~


vim +133 drivers/dma-buf/heaps/system_heap.c

   127	
   128	static struct sg_table *system_heap_map_dma_buf(struct dma_buf_attachment *attachment,
   129							enum dma_data_direction direction)
   130	{
   131		struct dma_heap_attachment *a = attachment->priv;
   132		struct sg_table *table = a->table;
 > 133		int attrs = attachment->dma_map_attrs;
   134		int ret;
   135	
   136		ret = dma_map_sgtable(attachment->dev, table, direction, attrs);
   137		if (ret)
   138			return ERR_PTR(ret);
   139	
   140		a->mapped = true;
   141		return table;
   142	}
   143	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip