On Tue, Jul 20, 2021 at 6:52 PM Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote: > Several new structs do not have any field documentation, but they do start with /**, > so I get complaints about missing field docs. > > After manually changing this to /*, I still get a few remaining warnings: Will fix in next version. > mtk-vcodec/vdec/vdec_h264_req_if.c:189: warning: Function parameter or member 'h264_slice_params' not described in 'vdec_h264_vsi' > mtk-vcodec/vdec/vdec_h264_req_if.c:210: warning: Function parameter or member 'h264_slice_param' not described in 'vdec_h264_slice_inst' > mtk-vcodec/vdec/vdec_h264_req_if.c:210: warning: Function parameter or member 'dpb' not described in 'vdec_h264_slice_inst' > > Can you fix this? Will fix in next version. > I also want to take this patch series at the same time: > > https://patchwork.linuxtv.org/project/linux-media/cover/20210630085247.27554-1-irui.wang@xxxxxxxxxxxx/ > > Can you verify that this would not cause any problems with your series? As far as > I can see it is fine, but a second pair of eyeballs wouldn't hurt. Series [1] shouldn't cause any problems with this series. However, series [1] doesn't apply after this series (conflicted with [2]). It needs to rebase and send another version after fixing the typo anyway. [1]: https://patchwork.linuxtv.org/project/linux-media/cover/20210630085247.27554-1-irui.wang@xxxxxxxxxxxx/ [2]: https://patchwork.linuxtv.org/project/linux-media/patch/20210630085247.27554-3-irui.wang@xxxxxxxxxxxx/