Hi Guillaume, On 30/07/2021 16:26, Guillaume Tucker wrote: > On 30/07/2021 14:32, kernel test robot wrote: >> Hi Guillaume, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on linuxtv-media/master] >> [also build test ERROR on v5.14-rc3 next-20210729] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: https://github.com/0day-ci/linux/commits/Guillaume-Tucker/media-vivid-drop-CONFIG_FB-dependency/20210729-191815 >> base: git://linuxtv.org/media_tree.git master >> config: m68k-allmodconfig (attached as .config) >> compiler: m68k-linux-gcc (GCC) 10.3.0 >> reproduce (this is a W=1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # https://github.com/0day-ci/linux/commit/51defc67cada10450046e4d4e7eda1a2573371cc >> git remote add linux-review https://github.com/0day-ci/linux >> git fetch --no-tags linux-review Guillaume-Tucker/media-vivid-drop-CONFIG_FB-dependency/20210729-191815 >> git checkout 51defc67cada10450046e4d4e7eda1a2573371cc >> # save the attached .config to linux build tree >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=m68k >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot <lkp@xxxxxxxxx> >> >> All errors (new ones prefixed by >>, old ones prefixed by <<): >> >>>> ERROR: modpost: "vivid_clear_fb" [drivers/media/test-drivers/vivid/vivid.ko] undefined! >>>> ERROR: modpost: "vivid_fb_release_buffers" [drivers/media/test-drivers/vivid/vivid.ko] undefined! >>>> ERROR: modpost: "vivid_fb_init" [drivers/media/test-drivers/vivid/vivid.ko] undefined! > > Pretty sure this is due to the conditional in the Makefile I > mentioned in an email yesterday, where it should have been > ifneq ($(CONFIG_FB),) for when CONFIG_FB=m. > > Let me know if I should send a v2 now with this fix, I was > waiting for Hans' feedback first. Go ahead and send a v2. I have just one comment: in vivid-core.c, please change this in the node_types MODULE_PARM_DESC: "\t\t bit 12: Radio Transmitter node\n" "\t\t bit 16: Framebuffer for testing overlays\n" "\t\t bit 17: Metadata Capture node\n" to: "\t\t bit 12: Radio Transmitter node\n" #ifdef CONFIG_FB "\t\t bit 16: Framebuffer for testing overlays\n" #endif "\t\t bit 17: Metadata Capture node\n" That way it is visible with modinfo whether or not framebuffer support is compiled in or not. Regards, Hans > > Thanks, > Guillaume >
