On Thu, 2021-07-29 at 15:36 +0200, Hans Verkuil wrote: > There is no reason for the cedrus driver to set min_buffers_needed. > A non-zero min_buffers_needed can cause problems with the Request API > if start_streaming fails when queueing a buffer from a request. > > Since it is not needed for this driver, just remove it. > > Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> > Cc: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx> > Cc: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx> Adding Daniel in Cc, I think he has a board ready to run some tests if needed. Having said that, Hantro doesn't use min_buffers_needed so this looks correct. Reviewed-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx> Thanks, Ezequiel > --- > drivers/staging/media/sunxi/cedrus/cedrus_video.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c > index c589fe9dae70..f3cd452575d4 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c > @@ -570,7 +570,6 @@ int cedrus_queue_init(void *priv, struct vb2_queue *src_vq, > src_vq->io_modes = VB2_MMAP | VB2_DMABUF; > src_vq->drv_priv = ctx; > src_vq->buf_struct_size = sizeof(struct cedrus_buffer); > - src_vq->min_buffers_needed = 1; > src_vq->ops = &cedrus_qops; > src_vq->mem_ops = &vb2_dma_contig_memops; > src_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY; > @@ -587,7 +586,6 @@ int cedrus_queue_init(void *priv, struct vb2_queue *src_vq, > dst_vq->io_modes = VB2_MMAP | VB2_DMABUF; > dst_vq->drv_priv = ctx; > dst_vq->buf_struct_size = sizeof(struct cedrus_buffer); > - dst_vq->min_buffers_needed = 1; > dst_vq->ops = &cedrus_qops; > dst_vq->mem_ops = &vb2_dma_contig_memops; > dst_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY; -- Kindly, Ezequiel
