On Mon, Jul 26, 2021 at 03:03:35PM +0300, Sakari Ailus wrote: > On Mon, Jul 26, 2021 at 02:55:51PM +0300, Andy Shevchenko wrote: > > On Mon, Jul 26, 2021 at 2:47 PM Sakari Ailus > > <sakari.ailus@xxxxxxxxxxxxxxx> wrote: > > > On Mon, Jul 26, 2021 at 11:40:55AM +0300, Andy Shevchenko wrote: > > > > ... > > > > > > err_free_swnodes: > > > > software_node_unregister_nodes(sensor->swnodes); > > > > err_put_adev: > > > > - acpi_dev_put(sensor->adev); > > > > + acpi_dev_put(adev); > > > > > > adev is assigned to sensor->adev before goto so the two have the same > > > value. I have no problem with the patch though. > > > > Are we reading the same version? Or am I missing something? > > Ah. I noticed the adev assignment was removed (and added later) by the > other patch. Yeah, agreed; this one's needed. Thanks! Can we have your tag? -- With Best Regards, Andy Shevchenko
