Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> > As a side note, it appears the struct dma_sgt_handle type is exposed > to users of the DMA-API by linux/dma-map-ops.h, but is has no users > or functions returning the type explicitly. > > This may indicate it's a good idea to move the struct dma_sgt_handle type > to drivers/iommu/dma-iommu.c. The decision is left to maintainers :-) linux/dma-map-ops.h is a helper header for the dma_ops implementations, not for users of the DMA API. sgt_handle, which references dma_sgt_handle is used in kernel/dma/mapping.c