Hi Saptarshi,
On Fri, Jul 16, 2021 at 01:19:10AM +0530, Saptarshi Patra wrote:
> media: usb: uvc: uvc_driver: Decleared a function called
> pr_info() with a string input "I changed uvcvideo driver in the Linux
> Kernel"
>
> Added the function pr_info() to see the message / input string using dmesg
I'm curious, could you explain why you think this should be merged in
the upstream kernel ? I fear the kernel log may get a bit too verbose if
everybody added their own little message :-)
> staging: android: Decleared file operation with const keyword
Don't combine multiple independent changes in a single patch.
> Warning found by the checkpatch.pl script
>
> Signed-off-by: Saptarshi Patra <saptarshi.patra.22@xxxxxxxxx>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 2 +-
> drivers/staging/android/ashmem.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 9a791d8ef200..0b47ca75091b 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2352,7 +2352,7 @@ static int uvc_probe(struct usb_interface *intf,
> (const struct uvc_device_info *)id->driver_info;
> int function;
> int ret;
> -
> + pr_info("I changed uvcvideo driver in the Linux Kernel\n");
> /* Allocate memory for the device and initialize it. */
> dev = kzalloc(sizeof(*dev), GFP_KERNEL);
> if (dev == NULL)
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index ddbde3f8430e..4c6b420fbf4d 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>
> static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
> {
> - static struct file_operations vmfile_fops;
> + static const struct file_operations vmfile_fops;
You haven't compiled this, have you ?
> struct ashmem_area *asma = file->private_data;
> int ret = 0;
>
--
Regards,
Laurent Pinchart
