Hi Viktor, On Mon, Jul 12, 2021 at 10:17 PM Viktor Prutyanov <viktor.prutyanov@xxxxxxxxxxxx> wrote: [...] > + max-fifo-level: > + maxItems: 1 > + description: > + Maximum IR TX FIFO fill level >From Documentation/devicetree/bindings/writing-bindings.rst: "DO use a vendor prefix on device specific property names. Consider if properties could be common among devices of the same class. Check other existing bindings for similar devices." I am not sure if there's a "common" fifo size property for IR transmitters though. Also in general I think it's good to write the schema for properties in a way so the binding validation can detect issues. For "common" properties (like clocks, interrupts, etc.) this is inherited by default However, for custom properties this needs to be defined manually. For this property I would add: $ref: /schemas/types.yaml#/definitions/uint32 (I think this can replace maxItems) And I would define the allowed value, from what I have seen in the vendor driver (which I am not sure about though!) that would be: const: 1024 Best regards, Martin
