Re: [PATCH v7 21/27] v4l: subdev: routing kernel helper functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

On Sun, Jun 06, 2021 at 02:29:42AM +0300, Laurent Pinchart wrote:
> > +{
> > +	int ret;
> > +
> > +	routing->which = state ? V4L2_SUBDEV_FORMAT_TRY : V4L2_SUBDEV_FORMAT_ACTIVE;
> 
> I think we could simplify this if we mandate subdev drivers to embed an
> instance of v4l2_subdev_state for the active state. We could then drop
> the .get_routing() operation. We could actually drop the .get_fmt()
> operation too, but that would be a long term goal. As .get_routing() is
> new, I'd rather not introduce it, and push drivers that need routing
> support to use v4l2_subdev_state.

Sounds good to me.

-- 
Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux