On Thu, Jul 08, 2021 at 04:14:04PM +0200, Hans de Goede wrote: > From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > [ Upstream commit 4ca052b4ea621d0002a5e5feace51f60ad5e6b23 ] > > Some devices reference an output terminal as the source of extension > units. This is incorrect, as output terminals only have an input pin, > and thus can't be connected to any entity in the forward direction. The > resulting topology would cause issues when registering the media > controller graph. To avoid this problem, connect the extension unit to > the source of the output terminal instead. > > While at it, and while no device has been reported to be affected by > this issue, also handle forward scans where two output terminals would > be connected together, and skip the terminals found through such an > invalid connection. > > Cc: stable@xxxxxxxxxxxxxxx # v5.10 > Reported-by: Hans de Goede <hdegoede@xxxxxxxxxx> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > drivers/media/usb/uvc/uvc_driver.c | 32 ++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) now applied, thanks. greg k-h